feat(maestro): split KYC dismiss test for webview and in-app browser#78
Closed
ignaciosantise wants to merge 1 commit intomasterfrom
Closed
feat(maestro): split KYC dismiss test for webview and in-app browser#78ignaciosantise wants to merge 1 commit intomasterfrom
ignaciosantise wants to merge 1 commit intomasterfrom
Conversation
Rename pay_kyc_back_navigation to pay_kyc_webview_dismiss (tag: pay-webview) for RN/Kotlin/Swift, and add pay_kyc_browser_dismiss (tag: pay-browser) for Flutter which uses InAppBrowser instead of WebView. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
There was a problem hiding this comment.
Pull request overview
This PR refactors the Maestro Pay KYC “dismiss” coverage by separating the flow into two platform-specific tests (native WebView vs in-app browser) and updates the test catalog documentation accordingly.
Changes:
- Renamed the KYC dismiss test to
pay_kyc_webview_dismissand tagged itpay-webview. - Added a new
pay_kyc_browser_dismisstest taggedpay-browserfor platforms using an in-app browser. - Updated the Pay tests README catalog and added tag-based run instructions per platform.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| maestro/pay-tests/README.md | Updates test catalog entries and documents platform-specific tag filtering. |
| maestro/pay-tests/.maestro/pay_kyc_webview_dismiss.yaml | Renames/retags the WebView-based KYC dismiss flow and updates recording/test name. |
| maestro/pay-tests/.maestro/pay_kyc_browser_dismiss.yaml | Adds a new in-app browser dismiss flow with platform-conditional close handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pay_kyc_back_navigationtopay_kyc_webview_dismisswith tagpay-webviewfor platforms using native WebView (RN, Kotlin, Swift)pay_kyc_browser_dismisstest with tagpay-browserfor Flutter, which uses InAppBrowser instead of WebViewCI usage
--include-tags pay,pay-webview--include-tags pay,pay-browserTest plan
pay_kyc_webview_dismissruns correctly on RN/Kotlin/Swift with--include-tags pay,pay-webviewpay_kyc_browser_dismissruns correctly on Flutter with--include-tags pay,pay-browser--include-tags pay🤖 Generated with Claude Code