Skip to content

Ankit | Test | On PDF digits after desimal are not coming as per setting#210

Open
ankitdubeyoffice wants to merge 1 commit intomasterfrom
master-child
Open

Ankit | Test | On PDF digits after desimal are not coming as per setting#210
ankitdubeyoffice wants to merge 1 commit intomasterfrom
master-child

Conversation

@ankitdubeyoffice
Copy link
Collaborator

…ON deserialization and update model properties from double to string types
@windsurf-bot
Copy link

windsurf-bot bot commented Mar 16, 2026

PR review rate limit exceeded

{
<td class="py-0 border-none border-right text-center">
@if (Entry?.SumOfDiscounts != null && Entry.SumOfDiscounts.AmountForAccount >= 0)
@if (Entry?.SumOfDiscounts != null && (decimal.TryParse(Entry.SumOfDiscounts.AmountForAccount, out var discAmt) ? discAmt >= 0 : true))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@if (Entry?.SumOfDiscounts != null && (decimal.TryParse(Entry.SumOfDiscounts.AmountForAccount, out var discAmt) ? discAmt >= 0 : true))
@if (Entry?.SumOfDiscounts != null && (!decimal.TryParse(Entry.SumOfDiscounts.AmountForAccount, out var discAmt) || discAmt >= 0))

{
<td class="text-right">
@if (Entry?.SumOfDiscounts != null && Entry.SumOfDiscounts.AmountForAccount >= 0)
@if (Entry?.SumOfDiscounts != null && (decimal.TryParse(Entry.SumOfDiscounts.AmountForAccount, out var discAmt) ? discAmt >= 0 : true))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@if (Entry?.SumOfDiscounts != null && (decimal.TryParse(Entry.SumOfDiscounts.AmountForAccount, out var discAmt) ? discAmt >= 0 : true))
@if (Entry?.SumOfDiscounts != null && (!decimal.TryParse(Entry.SumOfDiscounts.AmountForAccount, out var discount) || discount >= 0))

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do it in all below

{
<td class="text-right">
@if (Entry?.SumOfDiscounts != null && Entry.SumOfDiscounts.AmountForAccount >= 0)
@if (Entry?.SumOfDiscounts != null && (decimal.TryParse(Entry.SumOfDiscounts.AmountForAccount, out var discAmt) ? discAmt >= 0 : true))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optimise here also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants