Skip to content

Conversation

@ViaSocket-Git
Copy link
Collaborator

No description provided.

@Husainbw786
Copy link
Collaborator

/windsurf-review

Copy link

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other comments (4)
  • src/routes/utils_router.py (12-13) There's a naming inconsistency between the endpoint function name and the service function it calls. The endpoint function is named `delete_with_id_or_prefix` but it calls a function named `delete_with_id_prefix`. Consider renaming one of them for consistency.
  • src/services/cache_service.py (169-169) Missing type hints for the `id` parameter and return value in the `delete_with_id_prefix` function. Consider adding them to maintain consistency with the rest of the codebase.
  • src/services/cache_service.py (166-166) The `get_redis_cache_with_prefix` function uses `print()` for error logging while other functions in this file use `logger.error()`. Consider using `logger.error()` for consistency.
  • src/services/cache_service.py (177-177) There's an extra space after `await` in line 177.
                await delete_in_cache(prefix)
    

💡 To request another review, post a new comment with "/windsurf-review".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants