-
Notifications
You must be signed in to change notification settings - Fork 0
Split doc #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: testing
Are you sure you want to change the base?
Split doc #806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other comments (1)
- docs/components/services/ai-service-layer.md (552-552) The `execute_with_fallback_model()` function is called in the fallback handler but isn't defined anywhere in the documentation. Consider adding its implementation or clarifying how it relates to the rest of the code.
💡 To request another review, post a new comment with "/windsurf-review".
| service_mapping = { | ||
| "openai": UnifiedOpenAICase, | ||
| "openai_response": OpenaiResponse, | ||
| "anthropic": Antrophic, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the service mapping dictionary. The class name for Anthropic is misspelled as 'Antrophic'.
| "anthropic": Antrophic, | |
| "anthropic": Anthropic, |
| **File**: `src/services/commonServices/anthropic/anthropicCall.py` | ||
|
|
||
| ```python | ||
| class Antrophic(BaseService): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name for the Anthropic handler is misspelled as 'Antrophic'.
| class Antrophic(BaseService): | |
| class Anthropic(BaseService): |
| conversation = await self.create_conversation() | ||
|
|
||
| # Execute API call | ||
| response = await self.chats() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a potential infinite recursion issue in the code examples. In BaseService.chats(), it references self.runModel, but in the UnifiedOpenAICase.execute() method, it calls await self.chats() which would call itself recursively. The implementation should likely call await self.runModel() directly or use a different pattern.
No description provided.