feat: allow built-in PHP functions and constants in ReferenceUsedNamesOnly configuration #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uleset Updated the ReferenceUsedNamesOnly configuration to avoid importing built-in PHP functions and constants. Namespaced symbols continue to require imports. This makes the coding standard more natural and aligned with typical PHP coding practices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the ReferenceUsedNamesOnly sniff configuration to prevent importing PHP
built-in functions and constants while keeping strict importing rules for namespaced symbols.
Changes
Why
The previous configuration caused PHPCS and PHPCBF to auto-insert
use functionstatementsfor built-in functions like array_map() and implode(). This added noise and did not match
common PHP coding style.
Impact