Skip to content

feat(Application): Angular 21 upgrade#2315

Merged
hirokiterashima merged 13 commits into
developfrom
angular-21-upgrade
Jun 1, 2026
Merged

feat(Application): Angular 21 upgrade#2315
hirokiterashima merged 13 commits into
developfrom
angular-21-upgrade

Conversation

@hirokiterashima
Copy link
Copy Markdown
Member

@hirokiterashima hirokiterashima commented May 18, 2026

Changes

Test Prep

  • Run npm ci to get new dependencies. This PR also contains changes to fix the vulnerabilities in the dependencies.

Test

  • All the applications (Student, Teacher, Author) work as before

@qltysh
Copy link
Copy Markdown

qltysh Bot commented May 19, 2026

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (15)

RatingFile% DiffUncovered Line #s
New Coverage rating: A
...s/nodeGrading/filter-components/filter-components.component.ts100.0%
New Coverage rating: F
src/assets/wise5/common/dom/dom.ts100.0%
New Coverage rating: A
...move-user-confirm-dialog/move-user-confirm-dialog.component.ts100.0%
New Coverage rating: A
...torComponents/peer-group-button/peer-group-button.component.ts100.0%
New Coverage rating: A
...Asset/student-assets-dialog/student-assets-dialog.component.ts100.0%
New Coverage rating: A
src/test.ts100.0%
New Coverage rating: B
...ts/peerChat/peer-chat-messages/peer-chat-messages.component.ts100.0%
New Coverage rating: A
...e/open-response-show-work/open-response-show-work.component.ts100.0%
New Coverage rating: C
.../components/table/table-show-work/table-show-work.component.ts100.0%
New Coverage rating: A
...o-oscillator-show-work/audio-oscillator-show-work.component.ts100.0%
New Coverage rating: B
...rComponents/nodeGrading/node-grading/node-grading.component.ts100.0%
New Coverage rating: A
...e5/vle/studentAsset/student-assets/student-assets.component.ts100.0%
New Coverage rating: F
...s/student-summary-display/student-summary-display.component.ts100.0%
New Coverage rating: F
src/app/chatbot/chat-history-dialog.component.ts100.0%
New Coverage rating: D
...irectives/wise-tinymce-editor/wise-tinymce-editor.component.ts0.0%161-162
Total93.3%
🤖 Increase coverage with AI coding...
In the `angular-21-upgrade` branch, add test coverage for this new code:

- `src/assets/wise5/directives/wise-tinymce-editor/wise-tinymce-editor.component.ts` -- Line 161-162

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima marked this pull request as ready for review May 19, 2026 22:08
@hirokiterashima hirokiterashima requested a review from breity May 19, 2026 22:08
Copy link
Copy Markdown
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

I updated the TinyMCE skin files to the latest to fix some minor display bugs and removed deprecated plugins. I also updated tinymce-angular from 7 to 9.

@hirokiterashima hirokiterashima merged commit 4cd8ceb into develop Jun 1, 2026
1 check passed
@hirokiterashima hirokiterashima deleted the angular-21-upgrade branch June 1, 2026 19:41
@hirokiterashima
Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 5.231.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants