Skip to content

refactor(Application): Remove modules #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 51 commits into from
Dec 4, 2025
Merged

refactor(Application): Remove modules #2249

hirokiterashima merged 51 commits into from
Dec 4, 2025

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Dec 4, 2025

Changes

Test

Closes #

@hirokiterashima
Remove unused AiChatShowWorkModule
69493fa
@hirokiterashima
Remove unnecessary imports
c187f1a
@hirokiterashima
Remove unused PeerChatShowWorkModule
40cca13
@hirokiterashima
Remove ComponentServiceLookupServiceModule. Was only being used in test
99b22eb
@hirokiterashima
Remove SummaryStudentModule
20071d0
@hirokiterashima
Remove MatchStudentModule and MatchCommonModule. Import standalone co…
3dc598b 
…mponents instead.
@hirokiterashima
Remove HelpIconComponent dep. Import directly in places needed.
45477d0
@hirokiterashima
Remove PreviewComponentComponent dep. Import directly in places needed.
9dbf205
@hirokiterashima
Remove ComponentComponent and HighchartsChartModule. These are import…
56eac16 
…ed directly by components that use them
@hirokiterashima
Remove OpenResponseStudent module. Directly import component and prov…
3ea1d50 
…ide services instead where they're used.
@hirokiterashima
Ignore ComponentInfoDialogComponent tests for now. Will fix later.
eaeb70b
@hirokiterashima
Remove PauseScreenMenuComponent from ClassroomMonitorModule
27ab052
@hirokiterashima
Remove HighchartsChartModule from modules
0ffa5f8
@hirokiterashima
Remove NodeStatusIconComponent from StudentTeacherCommonModule. It's …
3d9cbc7 
…imported directly where it's used.
@hirokiterashima
Remove DialogResponsesComponent. It's imported by component that uses…
7654d34 
… it.
@hirokiterashima
Remove NodeIconComponent. It's imported by component that uses it.
b67d177
@hirokiterashima
Remove NotebookModule. It's imported by component that uses it.
b7391a9
@hirokiterashima
Remove StudentTeacherCommonModule
409f71b
@hirokiterashima
Remove StatusIconComponent from GradingCommonModule. It's imported by…
28b7ee6 
… component that uses it.
@hirokiterashima
Remove ComponentGradingComponent from modules. It's imported by compo…
9f1e87b 
…nents that use it.
@hirokiterashima
Remove ComponentStateInfoComponent from modules. It's imported by com…
58cf3c6 
…ponents that use it.
@hirokiterashima
Remove StudentComponentModule. It's imported by component that uses it.
8c3b222
@hirokiterashima
Remove GradingCommonModule. It's imported by component that uses it.
30e1822
@hirokiterashima
Remove ComponentAuthoringModule
861a418
@hirokiterashima
Clean up imports
3beed01
@hirokiterashima
EditNodeTitleComponent: move template inline
e16e4dd
@hirokiterashima
Remove StudentVLEModule and use StudentRoutingModule instead
beb0287
@hirokiterashima
Replace jquery with angular equivalent
f899369
@hirokiterashima
Merge pull request #2242 from WISE-Community/remove-modules-part-1
076c35d
@hirokiterashima
Remove milestone modules, move custom element definition to milestone…
5cc2ede 
…s component
@hirokiterashima
Remove redundant deps from ClassroomMonitorModule.
06aad3f
@hirokiterashima
Remove PeerGroupGradingModule. Redundant.
bdcf5fe
@hirokiterashima
Remove ClassroomMonitorModule move deps to TeacherToolsModule. Remove…
a091d1d 
… unnecessary RouterModule dep
@hirokiterashima
Remove StudentTeacherCommonServicesModule dep from ClassroomMonitorTe…
ab81de2 
…stingModule
@hirokiterashima
Removed PeerChatModule and imported components directly instead.
8b214fd
@hirokiterashima
Replace ngIf with new syntax
03e2a9d
@hirokiterashima
Replace ngFor with new syntax
e9e6e60
@hirokiterashima
Added comments on why we can't replace ShowGroup/MyWorkStudentModule …
12e4d57 
…with components
@hirokiterashima
Remove Dialog and Snack modules from ClassroomMonitorTesting module. …
10a7b39 
…Unused.
@hirokiterashima
Update tests to not use ComponentTypeService. Removed ComponentInfoDi…
a9b1554 
…alogComponent. Should be re-written from scratch.
@hirokiterashima
Replace ImportComponentRoutingModule with just a an array of Routes
ad21fb2
@hirokiterashima
Replace NodeAdvancedAuthoringRoutingModule with a simple array of Routes
ed31bc8
@hirokiterashima
Replace NodeAuthoringRoutingModule with a simple array of Routes
f2fa94e
@hirokiterashima
Replace StructureAuthoringRoutingModule with a simple array of Routes
b7b3287
@hirokiterashima
Replace AddLessonRoutingModule with a simple array of Routes. Fix ins…
0e327ed 
…ert lesson before button orientation
@hirokiterashima
Replace AddNodeRoutingModule with a simple array of Routes. Fix inser…
29c5867 
…t step before button orientation
@hirokiterashima
Replace AuthoringRoutingModule with a simple array of Routes
590f5a0
@hirokiterashima
Replace TeacherToolsRoutingModule with a simple array of Routes
7f81fc8
@hirokiterashima
Replace ForgotRoutingModule with a simple array of Routes
934eddd
@hirokiterashima
Replace HelpRoutingModule with a simple array of Routes
d01285e
@hirokiterashima
Merge pull request #2246 from WISE-Community/remove-modules-part-2
cdd09a3 
refactor(VLE): Remove modules part 2
@hirokiterashima hirokiterashima self-assigned this Dec 4, 2025
@qltysh
Copy link

qltysh bot commented Dec 4, 2025

❌ 1 blocking issue (1 total)

Tool Category Rule Count
qlty Structure Function with many parameters (count = 6): constructor 1 ❌

@qltysh
Copy link

qltysh bot commented Dec 4, 2025

Diff Coverage: The code coverage on the diff in this pull request is 83.7%.

Total Coverage: Unable to calculate total coverage change because base branch coverage was not found.

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima marked this pull request as ready for review December 4, 2025 19:53
@hirokiterashima hirokiterashima merged commit 89c01f0 into develop Dec 4, 2025
4 checks passed
@hirokiterashima hirokiterashima deleted the remove-modules branch December 4, 2025 19:57
@hirokiterashima
Copy link
Member Author

hirokiterashima commented Dec 4, 2025

🎉 This PR is included in version 5.199.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@hirokiterashima hirokiterashima

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hirokiterashima