-
Notifications
You must be signed in to change notification settings - Fork 5
refactor(Application): Convert remaining components to standalone #2247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Application): Convert remaining components to standalone #2247
Conversation
❌ 9 blocking issues (9 total)
|
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. 🚦 See full report on Qlty Cloud »🛟 Help
|
…rt RecaptchaV3Module in the component
…d to import RecaptchaV3Module in the component
… in my units page in curriculum. Removed ColorService and put the logic to get contract color in the TagComponent. There was no need for this to be a service
|
@breity, please test again. I fixed these issues that you found:
They were missing providers. I also took this opportunity to remove the ColorService and move the getContractColor logic into TagComponent because that's the only place it's used. Hopefully that's it, but let me know if you find more issues. |
breity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
Changes
Test