Skip to content

Conversation

@hirokiterashima
Copy link
Member

Changes

Test

Closes #

@qltysh
Copy link

qltysh bot commented Dec 5, 2025

❌ 3 blocking issues (3 total)

Tool Category Rule Count
qlty Duplication Found 26 lines of similar code in 2 locations (mass = 106) 3

@qltysh
Copy link

qltysh bot commented Dec 5, 2025

Qlty

Total Coverage: Coverage tags mismatch: head has [] but base only has []

🤖 Increase coverage with AI coding...

In the `use-inject-instead-of-constructor` branch, add test coverage for this new code:

- `src/app/modules/library/personal-library/personal-library.component.ts` -- Line 55
- `src/app/modules/library/share-project-dialog/share-project-dialog.component.ts` -- Line 87
- `src/app/notebook/notebook-launcher/notebook-launcher.component.ts` -- Line 17
- `src/app/notebook/notebook-notes/notebook-notes.component.ts` -- Line 54-69
- `src/app/notebook/notebook-parent/notebook-parent.component.ts` -- Line 18-30
- `src/app/notebook/notebook-report/notebook-report.component.ts` -- Line 49-127
- `src/assets/wise5/authoringTool/components/translatable-asset-chooser/translatable-asset-chooser.component.ts` -- Line 22
- `src/assets/wise5/authoringTool/peer-grouping/edit-peer-grouping-dialog/edit-peer-grouping-dialog.component.ts` -- Line 34-38
- `src/assets/wise5/classroomMonitor/classroomMonitorComponents/nodeGrading/node-class-responses/node-class-responses.component.ts` -- Line 31
- `src/assets/wise5/classroomMonitor/dataExport/export-one-workgroup-per-row/export-one-workgroup-per-row.component.ts` -- Line 25-26
- `src/assets/wise5/common/stepTools/step-tools.component.ts` -- Line 36
- `src/assets/wise5/components/animation/animation-authoring/animation-authoring.component.ts` -- Line 42
- `src/assets/wise5/components/conceptMap/concept-map-authoring/concept-map-authoring.component.ts` -- Line 33
- `src/assets/wise5/components/dialogGuidance/dialog-guidance-student/dialog-guidance-student.component.ts` -- Line 51
- `src/assets/wise5/components/discussion/discussion-show-work/discussion-show-work.component.ts` -- Line 18
- `src/assets/wise5/components/discussion/discussion-student/discussion-student.component.ts` -- Line 42-73
- `src/assets/wise5/components/draw/draw-authoring/draw-authoring.component.ts` -- Line 66
- `src/assets/wise5/components/draw/draw-show-work/draw-show-work.component.ts` -- Line 14
- `src/assets/wise5/components/embedded/embedded-authoring/embedded-authoring.component.ts` -- Line 31
- `src/assets/wise5/components/embedded/embedded-show-work/embedded-show-work.component.ts` -- Line 19-25
- `src/assets/wise5/components/graph/graph-show-work/graph-show-work.component.ts` -- Line 18
- `src/assets/wise5/components/graph/graphService.ts` -- Line 300
- `src/assets/wise5/components/label/label-show-work/label-show-work.component.ts` -- Line 20
- `src/assets/wise5/components/match/match-show-work/match-show-work.component.ts` -- Line 19
- `src/assets/wise5/components/match/match-student/match-student-default/match-student-default.component.ts` -- Line 55-204
- `src/assets/wise5/components/multipleChoice/multiple-choice-student/multiple-choice-student.component.ts` -- Line 76
- `src/assets/wise5/components/openResponse/open-response-student/open-response-student.component.ts` -- Lines 60 and 64
- `src/assets/wise5/components/outsideURL/outside-url-authoring/outside-url-authoring.component.ts` -- Line 68-69
- `src/assets/wise5/components/table/table-show-work/table-show-work.component.ts` -- Line 37-39
- `src/assets/wise5/directives/wise-tinymce-editor/wise-authoring-tinymce-editor.component.ts` -- Line 46
- `src/assets/wise5/services/notificationService.ts` -- Line 167-176
- `src/assets/wise5/themes/default/themeComponents/stepTools/step-tools.component.ts` -- Line 36

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants