Skip to content

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 29, 2025

Changes

  • Add location filter that looks at project.metadata.locations

Test prep

Sample project JSON:

{
...
  "metadata": {
        ...
        "locations": [
            {
                "id": "123",
                "level3": "Berkeley",
                "level2": "California",
                "level1": "USA"
            },
            {
                "id": "124",
                "level3": "Pinole",
                "level2": "California",
                "level1": "USA"
            },
            {
                "id": "125",
                "level2": "Kanagawa",
                "level1": "Japan"
            }
            {
                "id": "126",
                "level1": "Brazil"
            }
        ],
...
}

Test

  • Options appear in the locations filter in both the homepage unit listing and in the curriculum page
  • Selecting the options correctly filters the units
  • Location info appears in the unit info dialog

@hirokiterashima hirokiterashima self-assigned this Aug 29, 2025
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Aug 29, 2025
@hirokiterashima hirokiterashima marked this pull request as ready for review August 29, 2025 18:49
@hirokiterashima hirokiterashima requested a review from breity August 29, 2025 18:49
@hirokiterashima hirokiterashima changed the title Filter-unit-by-location feat(Unit Library): Filter units by location Aug 29, 2025
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@hirokiterashima hirokiterashima merged commit e770b6a into develop Sep 2, 2025
4 checks passed
@hirokiterashima hirokiterashima deleted the filter-unit-by-location branch September 2, 2025 20:49
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.193.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants