Skip to content

Conversation

@Aaron-Detre
Copy link
Contributor

Changes

  • Added an EditCRaterIdeaDescriptions component to the advanced settings of an Open Response component.
  • Made autoscrolling on the idea description authoring component turned on by default but with the option to turn it off since it is unnecessary (and doesn't work properly) in Open Response settings.
  • Changed references to "idea name" in EditCRaterIdeaDescriptions to "idea description" because that's a more descriptive name and I think should be less confusing given how CRaterIdea.name is referring to the ID. Also it matches the name of the class now which seems good.
  • Made CRaterIdea.detected optional to allow for ideas outside of the context of being detected or not. (I thought it already was optional, but maybe it got changed back or I'm just imagining it?)

Test

  • Make sure checking "Enable Student-Friendly Idea Descriptions" opens the EditCRaterIdeaDescriptions component.
  • Make sure that unchecking "Enable Student-Friendly Idea Descriptions" hides the EditCRaterIdeaDescriptions component but doesn't delete any created idea descriptions from the JSON.
  • Make sure that you can add and delete idea descriptions and that all changes are saved to the JSON.

Closes #2117

@Aaron-Detre Aaron-Detre self-assigned this Mar 26, 2025
@Aaron-Detre Aaron-Detre added the enhancement New feature of any size or improvement (UI, performance, security) label Mar 26, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review March 26, 2025 20:26
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described.

"Idea name" => "Idea description" sounds good.

I'm wondering if we need to even have a checkbox to "Enable Student-Friendly Idea Descriptions". I think every CRater item can (and should) have a rubric going forward, so the idea description component should always be "enabled". Maybe we should alway show the rubric, but let the author to collapse/expand the section since it takes up a lot of vertical space? What do you think?

Also, see my comments inline.

Base automatically changed from refactor-edit-open-response-advanced to develop April 2, 2025 20:41
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added minor code improvement suggestions to address before you merge. Remember to test using the pipeline.

@Aaron-Detre Aaron-Detre merged commit 8376c35 into develop Apr 9, 2025
1 check passed
@Aaron-Detre Aaron-Detre deleted the issue-2117-specify-text-for-ideas branch April 9, 2025 02:01
@hirokiterashima
Copy link
Member

🎉 This PR is included in version 5.174.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(OpenResponse): Allow authors to specify student-friendly text for ideas

3 participants