Skip to content

refactor(EditOpenResponseAdvancedComponent): Replace ngIf and ngFor statements #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aaron-Detre merged 2 commits into from
Apr 2, 2025
Merged

refactor(EditOpenResponseAdvancedComponent): Replace ngIf and ngFor statements #2129

Aaron-Detre merged 2 commits into from
Apr 2, 2025

Conversation

@Aaron-Detre
Copy link
Contributor

@Aaron-Detre Aaron-Detre commented Mar 25, 2025

Changes

  • Replaced ngIf and ngFor statements with @if and @for statements
  • Made other minor improvements

Test

  • Make sure open response advanced settings editor works normally

@Aaron-Detre Aaron-Detre self-assigned this Mar 25, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review March 25, 2025 19:41
@Aaron-Detre Aaron-Detre changed the title refactor(EditOpenResponseAdvancedComponent): Replaced ngIf and ngFor statements refactor(EditOpenResponseAdvancedComponent): Replace ngIf and ngFor statements Mar 25, 2025
hirokiterashima
hirokiterashima approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Remember that <div> by default breaks to the next line, so removing it will affect the layout.

@Aaron-Detre Aaron-Detre merged commit 543d4d5 into develop Apr 2, 2025
5 checks passed
@Aaron-Detre Aaron-Detre deleted the refactor-edit-open-response-advanced branch April 2, 2025 20:41
@hirokiterashima
Copy link
Member

hirokiterashima commented Apr 8, 2025

🎉 This PR is included in version 5.173.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@Aaron-Detre Aaron-Detre

Labels

Code Quality released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aaron-Detre @hirokiterashima