Skip to content

build(Application): Generate messages when new PR is made #2116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aaron-Detre merged 52 commits into from
Apr 3, 2025
Merged

build(Application): Generate messages when new PR is made #2116

Aaron-Detre merged 52 commits into from
Apr 3, 2025

Conversation

@Aaron-Detre
Copy link
Contributor

@Aaron-Detre Aaron-Detre commented Mar 13, 2025 •
edited
Loading

Changes

  • Created a new workflow that automatically updates messages.xlf when commits are made to a pull request.

Test

  • When making any PR, make sure the workflow runs extract-i18n.
    • If changes are made to messages.xlf, make sure the workflow commits/pushes them.
    • If changes aren't made to messages.xlf, make sure the workflow doesn't try to commit/push anything.
  • When making a PR to the develop branch, make sure that the develop branch workflow is run.
  • When making a PR to a non-develop branch, make sure that the non-develop branch workflow is run.

Closes #2103

@Aaron-Detre Aaron-Detre added enhancement New feature of any size or improvement (UI, performance, security) build labels Mar 13, 2025
@Aaron-Detre Aaron-Detre self-assigned this Mar 13, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review March 13, 2025 03:36
@Aaron-Detre Aaron-Detre marked this pull request as draft March 17, 2025 23:38
@Aaron-Detre Aaron-Detre changed the base branch from develop to issue-2117-specify-text-for-ideas April 3, 2025 16:24
@Aaron-Detre Aaron-Detre changed the base branch from issue-2117-specify-text-for-ideas to develop April 3, 2025 17:07
@Aaron-Detre Aaron-Detre marked this pull request as ready for review April 3, 2025 21:43
hirokiterashima
hirokiterashima approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaron-Detre Aaron-Detre merged commit 1c0a0b7 into develop Apr 3, 2025
1 check passed
@Aaron-Detre Aaron-Detre deleted the issue-2103-generate-messages branch April 3, 2025 21:49
@hirokiterashima
Copy link
Member

hirokiterashima commented Apr 8, 2025

🎉 This PR is included in version 5.173.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@Aaron-Detre Aaron-Detre

Labels

build enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build(Application): Generate messages when new PR is made

3 participants

@Aaron-Detre @hirokiterashima