-
Notifications
You must be signed in to change notification settings - Fork 5
feat(Dialog Guidance): Summary display for teachers #2115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dialog Guidance): Summary display for teachers #2115
Conversation
hirokiterashima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality works as described.
As we discussed today, let's change this component so that instead of showing just the "Most common ideas", we would
- show "Most common ideas" (shows top 3)
- show "Least common ideas" (shows top 3)
- show a link to "Show all ideas" (when clicked, shows all ideas in the rubric and their count)
Don't show any of the above if no ideas were detected by any of the students.
Also:
- add unit tests
- see inline comments for code improvement suggestions
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
hirokiterashima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes look good. 👍
I added code improvement suggestions on new code (and some older code that I had missed before).
Add i18n tags to elements and generate messages, and remember to add tests.
...e5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.html
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
...ise5/directives/teacher-summary-display/dialog-guidance-teacher-summary-display.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Can you do these before merge:
- Change fdescribe to describe
- Remove unused Config import in spec file
- Merge develop and regenerate messages. This should resolve the conflict
- Wait for @breity to review and style
|
🎉 This PR is included in version 5.173.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes
Test
Closes #2094