Skip to content

Conversation

@Aaron-Detre
Copy link
Contributor

@Aaron-Detre Aaron-Detre commented Mar 12, 2025

Changes

  • Added a teacher summary display for Dialog Guidance components that shows the ideas that the most students detected in the section.

Test

  • Teacher Tools > Grade by step > Dialog Guidance component > Step info
  • Make sure you can see the top 3 ideas detected (ordered from most common to least common) and the bottom 3 ideas detected (ordered from least common to most common).
  • Make sure the "see all ideas" link shows the all ideas section (ordered based on id).
  • Make sure the "hide all ideas" link hides the all ideas section.
  • Make sure that if no ideas have been detected, a message saying that ideas will show up here is displayed.

Closes #2094

@Aaron-Detre Aaron-Detre self-assigned this Mar 12, 2025
@Aaron-Detre Aaron-Detre added the enhancement New feature of any size or improvement (UI, performance, security) label Mar 12, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review March 12, 2025 23:40
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as described.

As we discussed today, let's change this component so that instead of showing just the "Most common ideas", we would

  • show "Most common ideas" (shows top 3)
  • show "Least common ideas" (shows top 3)
  • show a link to "Show all ideas" (when clicked, shows all ideas in the rubric and their count)

Don't show any of the above if no ideas were detected by any of the students.

Also:

  • add unit tests
  • see inline comments for code improvement suggestions

@hirokiterashima hirokiterashima changed the title feat(SummaryDisplay): Dialog guidance summary display for teachers feat(Dialog Guidance): Summary display for teachers Mar 17, 2025
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good. 👍

I added code improvement suggestions on new code (and some older code that I had missed before).

Add i18n tags to elements and generate messages, and remember to add tests.

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Can you do these before merge:

  1. Change fdescribe to describe
  2. Remove unused Config import in spec file
  3. Merge develop and regenerate messages. This should resolve the conflict
  4. Wait for @breity to review and style

@Aaron-Detre Aaron-Detre merged commit 3a8b376 into develop Apr 8, 2025
1 check passed
@Aaron-Detre Aaron-Detre deleted the issue-2094-dialog-guidance-teacher-summary-display branch April 8, 2025 20:59
@hirokiterashima
Copy link
Member

🎉 This PR is included in version 5.173.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(TeacherSummaryDisplayComponent): Add summary displays for DialogGuidance components

4 participants