Allow for Triangle v3 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use plot_triangulateio from GridVisualize.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the grid visualization functionality to support Triangle v3 by replacing the legacy plotting routines with the new plot_triangulateio! API from GridVisualize.
- Updated the test in runtests.jl to expect a CairoMakie.Scene instead of a CairoMakie.Figure.
- Refactored the builderplot function in src/plot.jl to use the new plot_triangulateio! API and adjusted its return behavior based on the reveal flag.
- Added necessary GridVisualize imports in src/SimplexGridFactory.jl to support the new plotting functions.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/runtests.jl | Updated test assertion for the new expected type (Scene) |
| src/plot.jl | Refactored builderplot to leverage plot_triangulateio! and updated docstring |
| src/SimplexGridFactory.jl | Added GridVisualize imports to support new plotting API |
Comments suppressed due to low confidence (1)
src/plot.jl:81
- [nitpick] Consider documenting that builderplot returns different types depending on the 'reveal' flag; this will help future developers understand the API behavior.
if reveal
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use plot_triangulateio from GridVisualize.