Add full directional wave examples and test#103
Open
jtgrasb wants to merge 1 commit intoWEC-Sim:devfrom
Open
Conversation
Contributor
|
Adam review how to add demonstration of these wave conditions as an application or alternative |
akeeste
approved these changes
Feb 5, 2026
Contributor
akeeste
left a comment
akeeste
left a comment
There was a problem hiding this comment.
Thanks @jtgrasb! Both cases work. My only comment is that since most of the two cases are identical, perhaps we merge MHKiT_NDBC_waves into OOI_waves by adding a commented code block in the input file where the MHKiT import and definition of waves can be used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two full directional wave examples using the
spectrumImportFullDirwave option using the IEC standard as updated by WEC-Sim/PR#1600. The first example is based on MHKiT's directional wave example and the second example converts the OOI format from the Pioneer Buoy model to the IEC standard.The tests will fail until WEC-Sim/PR#1600 is merged.