Potential fix for code scanning alert no. 2: Server-side request forgery #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/VisualDx/visualdx-api-diagnosis-proxy/security/code-scanning/2
To mitigate SSRF risks, we must validate or restrict the user-supplied path segment (
diagnosisId, and possibly alsoviewId) before using them to construct an internal API URL. The best general fix is to allow only expected, safe formats for these values—such as using a regex to ensure they're strictly alphanumeric (plus optionally dashes/underscores if needed) and do not contain slashes, dots, or other unsafe characters.Specifically, in
pages/api/diagnoses/[diagnosisId]/[viewId].js:apiUrl, validate thatdiagnosisId(and optionallyviewId) match a strict regular expression (e.g.,/^[a-zA-Z0-9_-]+$/).diagnosisIdandviewIdand before they are used.No new methods or imports are needed beyond what’s already present.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.