-
Notifications
You must be signed in to change notification settings - Fork 3
Restored full matrix of OS and Python versions. #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage 72.42% 72.42%
=======================================
Files 2 2
Lines 486 486
=======================================
Hits 352 352
Misses 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Test Results (py3.11 on ubuntu-22.04)48 tests 48 ✅ 1m 25s ⏱️ Results for commit fd51531. ♻️ This comment has been updated with latest results. |
Test Results (py3.10 on ubuntu-22.04)48 tests 48 ✅ 1m 27s ⏱️ Results for commit fd51531. ♻️ This comment has been updated with latest results. |
Test Results (py3.13 on ubuntu-22.04)48 tests 48 ✅ 1m 36s ⏱️ Results for commit fd51531. ♻️ This comment has been updated with latest results. |
Test Results (py3.12 on ubuntu-22.04)48 tests 48 ✅ 2m 29s ⏱️ Results for commit fd51531. ♻️ This comment has been updated with latest results. |
…calls Python 3.11+ has stricter error handling in subprocess.check_output() which causes tests to fail when vspace prompts for directory override confirmation. Solution: Add -f (force) flag to all subprocess.check_output(["vspace", ...]) calls to bypass interactive prompts in tests. Fixed 15 test files: - tests/FileOps/test_file_operations.py - tests/GridMode/test_multi_parameter.py - tests/Random/* (8 files) - tests/Vspace_* (5 files) This ensures tests run non-interactively on all Python versions (3.9-3.13). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Modified test files to include stderr=subprocess.STDOUT in subprocess.check_output() calls to capture error messages from vspace when tests fail on Python 3.11+. This will help diagnose the root cause of failures in: - test_gaussian_min_cutoff - test_gaussian_max_cutoff - test_gaussian_both_cutoffs - test_vspace_predefprior_npy - test_vspace_predefprior_txt
NumPy 2.0+ (used in Python 3.11+) no longer allows implicit conversion of 1-element arrays to scalars when assigning to array elements. This caused ValueError: 'setting an array element with a sequence' in the Gaussian and log-normal cutoff resampling code. Fixed by explicitly extracting the scalar value using [0] index for all 6 instances where np.random.normal() or np.random.lognormal() with size=1 is assigned to an array element. This resolves test failures on Python 3.11+ for: - test_gaussian_min_cutoff - test_gaussian_max_cutoff - test_gaussian_both_cutoffs - test_vspace_predefprior_npy - test_vspace_predefprior_txt All 48 tests now pass on both Python 3.9 and Python 3.11+.
Removed deprecated features section about Hyak PBS integration and updated recommendations for modern alternatives.
…vspace into comprehensive-testing
…netaryLaboratory/vspace into comprehensive-testing
Test Results (py3.14 on ubuntu-22.04)48 tests 48 ✅ 1m 11s ⏱️ Results for commit fd51531. ♻️ This comment has been updated with latest results. |
Modernize the pip-install workflow following the working BigPlanet template: - Update Python versions from 3.7-3.9 to 3.9-3.14 (matching project requirements) - Update OS matrix to use specific versions: macos-15-intel, macos-26, ubuntu-22.04, ubuntu-24.04 - Upgrade GitHub Actions versions: - actions/checkout@v3 → v4 - actions/setup-python@v4 → v5 - actions/upload-artifact@v3 → v4 - actions/download-artifact@v3 → v4 - Add allow-prereleases flag for Python 3.14 support - Replace deprecated pep517 with modern python -m build - Update build dependencies: add build, setuptools, wheel - Add artifact naming to prevent conflicts in multi-job builds - Modernize PyPI upload: - Use trusted publishing with id-token permissions - Update to pypa/gh-action-pypi-publish@release/v1 - Remove deprecated password-based authentication - Add merge-multiple for artifact downloads This ensures the release workflow follows current GitHub Actions and PyPI best practices.
Test Results (py3.9 on ubuntu-24.04)48 tests 48 ✅ 1m 18s ⏱️ Results for commit fd51531. |
Test Results (py3.14 on ubuntu-24.04)48 tests 48 ✅ 1m 4s ⏱️ Results for commit fd51531. |
Test Results (py3.11 on ubuntu-24.04)48 tests 48 ✅ 1m 18s ⏱️ Results for commit fd51531. |
Test Results (py3.10 on ubuntu-24.04)48 tests 48 ✅ 1m 22s ⏱️ Results for commit fd51531. |
Test Results (py3.13 on ubuntu-24.04)48 tests 48 ✅ 1m 23s ⏱️ Results for commit fd51531. |
Test Results (py3.12 on ubuntu-24.04)48 tests 48 ✅ 2m 29s ⏱️ Results for commit fd51531. |
No description provided.