Dev/andres&janier/v4.0 logout unused#171
Merged
Merged
Conversation
Switches unused assigned service cleanup to use the dedicated logout and release flow, ensuring proper session handling and resource management. Updates log message for clarity.
Updates the user service cleanup process to use a unified logout and release mechanism, ensuring proper handling of cached and released resources when user services are unused for too long. This change enhances resource management consistency across OS managers.
dkmstr
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way unused user services are handled for both Linux and Windows OS managers, as well as within the assigned unused worker. The main change is to replace direct service release calls with a more structured logout and release process, ensuring that the logout event is properly logged and that services are released in a way that supports pool caching if available.
Refactoring and behavior changes for unused service handling:
LinuxOsManagerandWindowsOsManagernow useosmanagers.OSManager.logged_outto log the logout event before releasing the service, instead of callinguserservice.release()directly. This makes the logout process more explicit and consistent. [1] [2]UserServiceManager.manager().release_from_logout, which manages whether the service is returned to the cache or fully released, depending on pool configuration. [1] [2]assigned_unused.py) is updated to use the same logout and release flow, ensuring consistency across the codebase.Logging and messaging improvements:
Imports and code organization:
UserServiceManagerandosmanagersin all affected files to support the new logout and release flow. [1] [2] [3]