Adds password as argument for Thincast RDP launch #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the logic for launching Thincast to pass the password as a command-line argument instead of writing it unencrypted to the RDP file. Improves security by avoiding plaintext password storage and ensures compatibility with Thincast's CLI options. Adjusts debug logging accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates how RDP sessions are launched on macOS, specifically for Thincast and xfreerdp clients. The main improvement is that passwords are now passed as command-line arguments instead of being written to the RDP file, enhancing security by avoiding plaintext password storage. The changes also ensure that passwords are only included when provided.
Security and Launch Parameter Improvements:
.rdpfile; instead, the password is now appended as a command-line argument (/p:<password>) when launching Thincast, improving security and avoiding plaintext password storage. [1] [2]/p:<password>argument when necessary. If no password is provided, this is logged for debugging purposes. [1] [2] [3]Signature Updates:
.signaturefiles for bothdirect.pyandtunnel.pyto reflect the code changes. [1] [2]