Skip to content

Conversation

@No0ne558
Copy link
Contributor

@No0ne558 No0ne558 commented Jan 4, 2026

Summary

This PR fixes critical double-touch triggering bugs in form zones and begins improvements to the Order Comment dialog keyboard interface.

Changes

1. Fixed ListField Double-Touch and Click Area Issues

  • Problem: Touchscreen inputs were triggering field actions twice due to both Touch and Mouse events calling FormZone::Touch()
  • Solution: Changed ListFormZone::Touch() and ListFormZone::Mouse() to call LayoutZone::Touch() instead, which only updates coordinates without triggering field actions
  • Click Area Fix: Corrected ListField offset calculation from label_width + .6 to label_width + 1 and boundary from entry_width + 1 to entry_width to match visual button boundaries
  • Impact: Tender Settings and all form zones with list fields now respond correctly to single clicks/taps without double-triggering

2. Order Comment Dialog Improvements (Work in Progress)

  • Redesigned dialog with modern 6-row QWERTY keyboard layout (removed overlapping keyboard layers)
  • Implemented visible text entry box at top of dialog with absolute positioning
  • Fixed text display updates - typed characters now appear in RED as user types
  • Added proper background clearing to prevent text artifacting when clearing input
  • Adjusted text positioning for better vertical centering in entry box
  • Status: Text entry box is functional and visible. Still polishing final implementation.

Files Modified

  • zone/form_zone.cc - ListFormZone Touch/Mouse handlers, ListField Touch detection
  • zone/user_edit_zone.cc - JobSecurityZone touch handling
  • zone/dialog_zone.cc - OrderCommentDialog constructor, Render, RenderEntry, DrawEntry, Signal methods
  • zone/dialog_zone.hh - OrderCommentDialog interface changes
  • docs/changelog.md - Documentation of changes

Testing

  • ListField buttons in Tender Settings respond to single touch/click
  • ListField click area matches visual button boundaries
  • Order Comment dialog displays keyboard without overlap
  • Text entry box is visible and positioned correctly
  • Order Comment dialog fully tested (work in progress)

- Fixed double-triggering when using touchscreen by changing ListFormZone handlers to use LayoutZone::Touch instead of FormZone::Touch
- Fixed ListField click detection offset from .6 to 1 and boundary to match visual button area
- Resolves issues in Tender Settings and all form zones with list fields
- Fixed double-triggering in ListFormZone by calling LayoutZone::Touch instead of FormZone::Touch
- Fixed ListField click area boundaries to match visual button size
- Redesigned Order Comment dialog with 6-row QWERTY keyboard layout
- Added visible text entry box with absolute positioning
- Implemented text display updates showing typed characters in RED
- Added proper background clearing to prevent artifacting
- Adjusted text positioning for better centering

Work in progress: Still polishing the dialog keyboard implementation
@No0ne558 No0ne558 merged commit d12198a into ViewTouch:dev Jan 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant