reconcile: update statefulset status on success for OnDelete update strategy#2207
Open
AndrewChubatiuk wants to merge 1 commit into
Open
reconcile: update statefulset status on success for OnDelete update strategy#2207AndrewChubatiuk wants to merge 1 commit into
AndrewChubatiuk wants to merge 1 commit into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
AndrewChubatiuk
force-pushed
the
update-sts-status-for-ondelete-strategy
branch
from
3c8907d to
390b88e
Compare
vrutkovs
requested changes
May 25, 2026
| } | ||
| logger.WithContext(ctx).Info(fmt.Sprintf("updating statefulset=%s/%s status currentRevision from %q to %q", nsn.Namespace, nsn.Name, sts.Status.CurrentRevision, updateRevision)) | ||
| sts.Status.CurrentRevision = updateRevision | ||
| sts.Status.CurrentReplicas = replicas |
Collaborator
There was a problem hiding this comment.
Not sure why are we using desired number of replicas here - my understanding we should read status.updatedReplicas, which corresponds to the replicas from updateRevision
Contributor
Author
There was a problem hiding this comment.
status is only updated in case of success or if no actions are needed, which means statefulset is in desired state, where replicas count is equal to expected and all of them are healthy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1242
Summary by cubic
Update StatefulSet status for OnDelete strategy by setting status.currentRevision to status.updateRevision and syncing currentReplicas after pods converge or when no updates are needed. Prevents stale status in monitoring and fixes #1242.
Written for commit 390b88e. Summary will update on new commits. Review in cubic