Skip to content

Remove redundant types #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennytv merged 1 commit into from
May 8, 2026
+5 −7
Merged

Remove redundant types #1259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions ...ain/java/com/viaversion/viabackwards/protocol/v1_19_3to1_19_1/Protocol1_19_3To1_19_1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@
public final class Protocol1_19_3To1_19_1 extends BackwardsProtocol<ClientboundPackets1_19_3, ClientboundPackets1_19_1, ServerboundPackets1_19_3, ServerboundPackets1_19_1> {

public static final BackwardsMappingData MAPPINGS = new BackwardsMappingData("1.19.3", "1.19", Protocol1_19_1To1_19_3.class);
public static final ByteArrayType.OptionalByteArrayType OPTIONAL_SIGNATURE_BYTES_TYPE = new ByteArrayType.OptionalByteArrayType(256);
public static final ByteArrayType SIGNATURE_BYTES_TYPE = new ByteArrayType(256);
private final EntityPacketRewriter1_19_3 entityRewriter = new EntityPacketRewriter1_19_3(this);
private final BlockItemPacketRewriter1_19_3 itemRewriter = new BlockItemPacketRewriter1_19_3(this);
private final ParticleRewriter<ClientboundPackets1_19_3> particleRewriter = new ParticleRewriter<>(this);
Expand Down Expand Up @@ -227,9 +225,9 @@ public void register() {
throw new RuntimeException(e);
}

wrapper.write(Protocol1_19_3To1_19_1.OPTIONAL_SIGNATURE_BYTES_TYPE, signature); // Signature
wrapper.write(Types.OPTIONAL_SIGNATURE_BYTES, signature); // Signature
} else {
wrapper.write(Protocol1_19_3To1_19_1.OPTIONAL_SIGNATURE_BYTES_TYPE, null); // Signature
wrapper.write(Types.OPTIONAL_SIGNATURE_BYTES, null); // Signature
}

//TODO is this fine (probably not)? same for chat_command
Expand Down Expand Up @@ -273,7 +271,7 @@ public void register() {
}

wrapper.write(Types.STRING, argument.key());
wrapper.write(Protocol1_19_3To1_19_1.SIGNATURE_BYTES_TYPE, signature);
wrapper.write(Types.SIGNATURE_BYTES, signature);
}
} else {
wrapper.write(Types.VAR_INT, 0); // No signatures
Expand All @@ -293,7 +291,7 @@ public void register() {
public void register() {
read(Types.UUID); // Sender
read(Types.VAR_INT); // Index
read(OPTIONAL_SIGNATURE_BYTES_TYPE); // Signature
read(Types.OPTIONAL_SIGNATURE_BYTES); // Signature
handler(wrapper -> {
final String plainContent = wrapper.read(Types.STRING);
wrapper.read(Types.LONG); // Timestamp
Expand All @@ -302,7 +300,7 @@ public void register() {
for (int i = 0; i < lastSeen; i++) {
final int index = wrapper.read(Types.VAR_INT);
if (index == 0) {
wrapper.read(SIGNATURE_BYTES_TYPE);
wrapper.read(Types.SIGNATURE_BYTES);
}
}

Expand Down