Map BLOCK_CHANGED_ACK to BLOCK_UPDATE in 1.19 -> 1.18.2#1250
Open
calcastor wants to merge 1 commit intoViaVersion:masterfrom
Open
Map BLOCK_CHANGED_ACK to BLOCK_UPDATE in 1.19 -> 1.18.2#1250calcastor wants to merge 1 commit intoViaVersion:masterfrom
calcastor wants to merge 1 commit intoViaVersion:masterfrom
Conversation
calcastor
force-pushed
the
block_changed_ack_1_18_2
branch
from
b407a96 to
9bad888
Compare
calcastor
changed the title
calcastor
force-pushed
the
block_changed_ack_1_18_2
branch
4 times, most recently
from
bdc1e2d to
5b9835f
Compare
calcastor
changed the title
calcastor
force-pushed
the
block_changed_ack_1_18_2
branch
2 times, most recently
from
a42b273 to
158fee2
Compare
calcastor
force-pushed
the
block_changed_ack_1_18_2
branch
from
158fee2 to
9e29343
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Likely addresses #798
This PR re-implements BlockAckStorage from 15a5e6f, though changing its scope to also cache and store block updates to work around BLOCK_CHANGED_ACK only carrying a sequence number.
We cache data in BlockAckStorage from 1.19 LEVEL_CHUNK_WITH_LIGHT, BLOCK_UPDATE, and SECTION_BLOCKS_UPDATE packets, and cleanup with FORGET_LEVEL_CHUNK.