-
Notifications
You must be signed in to change notification settings - Fork 1
Add Dockerfile for building in ART #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Dockerfile.art
Outdated
| @@ -0,0 +1,43 @@ | |||
| FROM golang:1.23 AS builder | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have updated all our builds to Go 1.24 recently (the patch version is what we currently build with, don't know if this is less explicit in ART):
| FROM golang:1.23 AS builder | |
| FROM golang:1.24.6 AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We replace the golang builds with whats defined in the config, whose source is here, so regardless of the value defined here, go 1.24.6 will be used in production.
So golang:1.24 should be enough. In the future, we will raise PRs to bump the golang builds from golang:1.23 to golang:1.24 if a similar thing should happen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to 1.24 for now for clarity eae1f75
Dockerfile.art
Outdated
| ARG OPA_OPENSHIFT_COMMIT | ||
| ARG OPA_OPENSHIFT_URL | ||
| LABEL com.redhat.component="opa-openshift-container" \ | ||
| cpe="cpe:/a:redhat:logging:6.3::el9" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opa-openshift and observatorium-api are built from the same source in all 6.y releases. Is this something that we need to change in ART, for example by having per-release branches again?
Dockerfile.art
Outdated
| io.openshift.tags="openshift,logging,loki" \ | ||
| maintainer="AOS Logging <team-logging@redhat.com>" \ | ||
| name="openshift-logging/opa-openshift-rhel9" \ | ||
| release="6.3" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment.
Dockerfile.art
Outdated
| ENV OS_GIT_MINOR=1 | ||
| ENV OS_GIT_PATCH=0 | ||
|
|
||
| COPY ./opa-openshift /opt/app-root/src/opa-openshift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This COPY command works in the context of our Konflux build where the Dockerfile is one level up from the rest of the source... will this be the same for the ART build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the catch updated in eae1f75
Dockerfile.art
Outdated
| ENV BUILD_VERSION=0.1.0 | ||
| ENV OS_GIT_MAJOR=0 | ||
| ENV OS_GIT_MINOR=1 | ||
| ENV OS_GIT_PATCH=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are an artifact of CPaaS and can be removed:
| ENV BUILD_VERSION=0.1.0 | |
| ENV OS_GIT_MAJOR=0 | |
| ENV OS_GIT_MINOR=1 | |
| ENV OS_GIT_PATCH=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in eae1f75
Dockerfile.art
Outdated
| @@ -0,0 +1,43 @@ | |||
| FROM golang:1.23 AS builder | |||
|
|
|||
| ENV GOEXPERIMENT=strictfipsruntime | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this experiment is only available in the Red Hat custom build of Go and not in the library/golang image.
Onboard to ART