feat: hidden assets when Isolation mode group delist #5608
Conversation
🦋 Changeset detectedLatest commit: 2ba15d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR adds logic to
Confidence Score: 5/5Safe to merge; the filtering logic is correct and the isIsolated guard is properly in place The implementation change is small and self-contained. The guard condition correctly gates on The spec file's third new test case should be updated to use an isolated group to actually exercise the intended code path Important Files Changed
Reviews (2): Last reviewed commit: "chore: trim comment" | Re-trigger Greptile |
Coverage Report for ./apps/evm
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@greptile review again |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
| const mainAssetSettings = assetSettings.find( | ||
| settings => | ||
| settings.vToken.underlyingToken.symbol.toLowerCase() === | ||
| extendedEModeGroup.name.toLowerCase(), | ||
| ); |
There was a problem hiding this comment.
I think this is risky, as the product team might decide to stop following this convention in the future.
By definition, isolated groups only contain an isolated token and a stablecoin. What I propose is to detect whether any of the tokens within that group are paused and to hide the group by default if that's the case.
Also, we should only hide these from the results if showPausedAssets is false.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Jira ticket(s)
VPD-1291
Changes