Skip to content

Feat/vai error show #5605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cuzz-venus wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −1
Open

Feat/vai error show #5605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bbaec9
feat: remove raw translate key
cuzz-venus May 27, 2026
4cd37cd
feat: remove raw translate key
cuzz-venus May 27, 2026
c85bf96
feat: remove raw translate key
cuzz-venus May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fast-drinks-stop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@venusprotocol/evm": patch
---

feat: remove raw translate key on vai
4 changes: 3 additions & 1 deletion apps/evm/src/containers/Form/RhfTokenTextField/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@ export type RhfTokenTextFieldProps<TFormValues extends FieldValues> = {
name: Path<TFormValues>;
control: Control<TFormValues>;
rules?: RegisterOptions;
hideErrorDescription?: boolean;
} & Omit<TokenTextFieldProps, 'value' | 'onChange'>;

export const RhfTokenTextField = <TFormValues extends FieldValues>({
name,
rules,
control,
hideErrorDescription = false,
...tokenTextFieldProps
}: RhfTokenTextFieldProps<TFormValues>) => {
const formState = useFormState({ control });
Expand All @@ -40,7 +42,7 @@ export const RhfTokenTextField = <TFormValues extends FieldValues>({
hasError={hasError}
disabled={field.disabled || formState.isSubmitting || tokenTextFieldProps.disabled}
description={
hasError && fieldState.error ? (
!hideErrorDescription && hasError && fieldState.error ? (
<p className="text-red">{fieldState.error.message}</p>
) : undefined
}
Expand Down
1 change: 1 addition & 0 deletions apps/evm/src/pages/Vai/Borrow/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ export const Borrow: React.FC = () => {
name="amountTokens"
rules={{ required: true }}
disabled={!isUserConnected || isUserMissingPrimeToken}
hideErrorDescription
Copy link
Copy Markdown
Member

@therealemjy therealemjy May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend taking a different approach.

This form is behaving differently in the sense that we use a custom UI to show errors. The designs were made quite a while ago and so I think we'd be better off staying consistent with the newest form.

So the approach I propose is to update the useForm hook of this component so that the error that's set on the field isn't an error code but rather the full error message. This means the RhfTokenTextField component won't need to be updated and will natively display the human-friendly error message.

token={vai}
rightMaxButton={{
label: t('vai.borrow.amountTokensInput.limitButtonLabel'),
Expand Down
1 change: 1 addition & 0 deletions apps/evm/src/pages/Vai/Repay/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ export const Repay: React.FC = () => {
name="amountTokens"
rules={{ required: true }}
disabled={!isUserConnected}
hideErrorDescription
token={vai}
rightMaxButton={
limitTokens
Expand Down
Loading