feat: landing page style update#5581
Conversation
🦋 Changeset detectedLatest commit: b7cb29c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR delivers a visual refresh of the landing page, navbar, and markets page: the "Start now" CTA moves below the Venus TVL figure on the hero, the Highest APY card is hidden below
Confidence Score: 5/5Safe to merge — changes are scoped to UI layout, a new optional dropdown prop, and a table card-sorting guard; no data-flow or contract logic is altered. All changed paths are presentational. The No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "feat: style update" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| {({ isDropdownOpened }) => ( | ||
| <button | ||
| className={cn( | ||
| sharedContainerClassName, | ||
| 'flex items-center justify-between cursor-pointer xl:gap-x-2', | ||
| isDropdownOpened && 'xl:text-white xl:bg-dark-blue-active', | ||
| )} | ||
| type="button" | ||
| onClick={handleToggleDropdown} | ||
| > | ||
| <span>{item.label}</span> | ||
|
|
||
| <Icon name="chevronDown" className={cn('size-3', isSubMenuOpen && 'rotate-180')} /> | ||
| <Icon name="chevronDown" className={cn('size-3', isDropdownOpened && 'rotate-180')} /> | ||
| </button> | ||
| )} |
There was a problem hiding this comment.
The button inside the XL-and-up Dropdown no longer has an onClick handler. Keyboard users who Tab to this element and press Enter or Space receive no response because the only interaction path is onMouseEnter/onMouseLeave on the outer wrapper. Any user navigating the site via keyboard cannot open the Markets (or similar) sub-menu at the xl breakpoint.
There was a problem hiding this comment.
I think keyboard-only desktop users (≥ 1280px, no mouse, no touchscreen) don't exist in DeFi 😢 — wallet flows are inherently mouse/touch driven, so this regression isn't worth fixing.
There was a problem hiding this comment.
That's a reasonable product call for your specific user base. A few counterpoints worth considering:
- Power users and developers frequently navigate via keyboard even in DeFi — they're a small but vocal cohort.
- Screen reader users (who do exist in DeFi) rely on keyboard navigation, and this breaks their flow on the nav menus.
- WCAG compliance — depending on jurisdiction, accessibility requirements can carry legal weight even for financial dApps.
That said, if it's a deliberate tradeoff you're comfortable with, fair enough.
Tip: You can give me more context with .greptile/rules.md so I get this right next time.
|
@greptile review again |
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
1 participant
Jira ticket(s)
VPD-1145
Changes
Landing — Hero
Start nowCTA from inside the Highest APY card to below the Venus TVL number, linkingto Venus Core Market (sized to Figma:
py-2 px-20).xl(1280px); desktop only.NavBar — Markets / Others menus
triggerOnHoverprop to the sharedDropdown; other consumers unchanged).defaultOpenOnMobileflag onSubMenu, setonly on Markets).
Markets page
Sort byselect hidden — addeddisableCardsSortingtoMarketTable, which derives acardColumnsarray withsortRowsstripped.TableCardsthen computes empty options and skips theselect. Desktop column sorting and the other 4
MarketTablecallers are unaffected.