-
Notifications
You must be signed in to change notification settings - Fork 0
For Review #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Velink
wants to merge
3
commits into
development
Choose a base branch
from
main
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
For Review #3
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +0,0 @@ | ||
| Google Search Engine API - Futureproof | ||
|
|
||
| Installation: | ||
|
|
||
| - Clone or download this repo | ||
| - Navigate to the client folder | ||
| - Run npm install to install dependencies | ||
| - Navigate to the server folder | ||
| - Run npm install to install dependencies | ||
|
|
||
| Usage: | ||
|
|
||
| - Navigate to the server directory | ||
| - Run node index.js to launch server | ||
| - Run nodemon index.js to launch server using nodemon | ||
| - Go into script.js and read the chain of functions carefully to understand how the search engine works | ||
| - The index.html file is served on localhost:3000 using express.static | ||
|
|
||
| Wins: | ||
|
|
||
| - Managed to implement our own search engine by chaining different functions | ||
| - Managed to display the ordered results from our search engine to our index.html | ||
|
|
||
| Challenges: | ||
|
|
||
| - Figuring out how to sort our data objects based on the user input | ||
| - Looping through the user input array and our data array, and returning a result which is soted from most relevant to least relevant | ||
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,67 +0,0 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <link rel="stylesheet" href="styles.css"> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.4/css/all.min.css" integrity="sha512-1ycn6IcaQQ40/MKBW2W4Rhis/DbILU74C1vSrLJxCq57o941Ym01SwNsOMqvEBFlcgUa6xLiPY/NS5R+E6ztJQ==" crossorigin="anonymous" referrerpolicy="no-referrer" /> | ||
| <script defer src="./script.js"></script> | ||
| <title>Google</title> | ||
| </head> | ||
| <body> | ||
| <!-- Navbar --> | ||
| <nav id="navbar"> | ||
| <ul id="nav-ul-1"> | ||
| <li><a href="">About</a></li> | ||
| <li><a href="">Store</a></li> | ||
| </ul> | ||
| <ul id="nav-ul-2"> | ||
| <li><a href="">Gmail</a></li> | ||
| <li><a href="">Images</a></li> | ||
| <li><a href=""><img class="dots-img" src="./assets/3x3dot-black.svg.png" alt="" width="19px" height="19px"></a></li> | ||
| <li><a href="">Sign In</a></li> | ||
| </ul> | ||
| </nav> | ||
|
|
||
| <!-- Logo and Search Bar and Buttons--> | ||
|
|
||
| <img id="google-logo" src="./assets/googlelogo_color_272x92dp.png" alt=""> | ||
| <form class="form" action="" method="" role=""> | ||
|
|
||
| <div id="search-container"> | ||
| <div id="search-icon"><img src="./assets/Google_Magnifying_Glass.svg.png" alt="" width="20px"></div> | ||
|
|
||
| <div id="search-input-container"> <input id="search" type="text" autofocus></div> | ||
| <div id="mic-icon"><img src="./assets/Google_mic.svg.png" alt="" width="16px"></div> | ||
| </div> | ||
| <div class="buttons-container"> | ||
| <input id="google-search" class="button" type="submit" value="Google Search"> | ||
| <input id="feeling-lucky" class="button" type="button" value="I'm Feeling Lucky"> | ||
| </div> | ||
| </form> | ||
|
|
||
| <!-- Links Section --> | ||
| <section id="link-section"> | ||
| </section> | ||
|
|
||
| <!-- Footer --> | ||
| <div class="footer"> | ||
| <div class="footer-banner">United Kingdom</div> | ||
| <div class="footer-carbon"> | ||
| <ul id="footer-ul-1"> | ||
| <li>Advertising</li> | ||
| <li>Business</li> | ||
| <li>How Search Works</li> | ||
| </ul> | ||
| <a href=""><img id="leaf" src="./assets/leaf.png" width="12px" height="14px">Carbon neutral since 2007</a> | ||
| <ul id="footer-ul-2"> | ||
| <li>Privacy</li> | ||
| <li>Terms</li> | ||
| <li>Settings</li> | ||
| </ul> | ||
| </div> | ||
| </div> | ||
|
|
||
| </body> | ||
| </html> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. html is great |
||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice readme - very helpful - would like to see some formatting