fix null pointer dereference

[S1gmaToeSniffer420]

line 388 was using a single assignment operator opposed to a comparison operator.
this made it so that pLabel was never initialized, leaving m_playerName as null.

[S1gmaToeSniffer420]

again, sorry for the confusion earlier.

[zackgood991]

They look the same to me...

[S1gmaToeSniffer420]

the assignment using = silently fails when GetFreeVoiceLabel() returns NULL, and later code might assume pLabel was initialized, making a null pointer deref.

[a1batross]

You sure about that?

Because that's not how the assignment in if works. pLabel does get assigned to whatever the function returns and then gets compared for non-zero value. If the function returns NULL, pLabel becomes NULL and the branch won't execute.

Aside from dubious readability of this trick, it's harmless.

[S1gmaToeSniffer420]

i mean, when i first ported the client to OpenBSD, it would always crash. but after debugging it, i changed it, and for some reason, it would not crash anymore. i probably fixed something else.
would it be useful if i were to replicate the crash again?

[a1batross]

When the engine crashes, it shows the backtrace info.

You could as well run it under GDB and to see why it crashes in more detail.

[S1gmaToeSniffer420]

alright, i'll get back to you once i've replicated it.