Skip to content

Conversation

@amrit110
Copy link
Member

Summary

Clickup Ticket(s): Link(s) if applicable.

Type of Change

  • πŸ› Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“ Documentation update
  • πŸ”§ Refactoring (no functional changes)
  • ⚑ Performance improvement
  • πŸ§ͺ Test improvements
  • πŸ”’ Security fix

Changes Made

  • Move ReadOnlySqlDatabase import in async_client_manager.py to use TYPE_CHECKING for type hints and local imports at runtime, resolving circular dependency with tools.web module.

Testing

  • Tests pass locally (uv run pytest tests/)
  • Type checking passes (uv run mypy <src_dir>)
  • Linting passes (uv run ruff check src_dir/)
  • Manual testing performed (describe below)

Manual testing details:

Screenshots/Recordings

Related Issues

Deployment Notes

Checklist

  • Code follows the project's style guidelines
  • Self-review of code completed
  • Documentation updated (if applicable)
  • No sensitive information (API keys, credentials) exposed

@amrit110 amrit110 closed this Feb 12, 2026
@amrit110 amrit110 deleted the ak/fix_circular_import branch February 12, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant