Add evaluation script for knowledgeqa #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrit110
changed the title
Member
Author
|
@fcogidi, i have to refactor my judges code after your factory PR gets merged. |
lotif
requested changes
Feb 10, 2026
| ground_truth: str, | ||
| answer_type: str = "Single Answer", | ||
| ) -> JudgeResult: | ||
| """Async version of evaluate.""" |
| elif "```" in response_text: | ||
| start = response_text.find("```") + 3 | ||
| end = response_text.find("```", start) | ||
| response_text = response_text[start:end].strip() |
Collaborator
There was a problem hiding this comment.
Again this block of code, now it's the 3 strike rule.
| config=types.GenerateContentConfig( | ||
| temperature=self._temperature, | ||
| ), | ||
| ) |
Collaborator
There was a problem hiding this comment.
There is a function called _call_llm_async with this exact block of code. It also appears a couple of times again in other files. Can it be put into a function that does that instead of repeating it?
| elif "```" in response_text: | ||
| start = response_text.find("```") + 3 | ||
| end = response_text.find("```", start) | ||
| response_text = response_text[start:end].strip() |
Collaborator
There was a problem hiding this comment.
Repeated code again, with the block above repeated as well.
| global _judge # noqa: PLW0603 | ||
| if _judge is not None: | ||
| _judge.close() | ||
| _judge = None |
Collaborator
There was a problem hiding this comment.
It will be a better implementation if we wrap those functions and the global var in a class do the singleton approach the same way we do with AsyncClientManager.
16 tasks
…val-agents into ak/add_evaluate_script
…val-agents into ak/add_evaluate_script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clickup Ticket(s): Link(s) if applicable.
Type of Change
Changes Made
Testing
uv run pytest tests/)uv run mypy <src_dir>)uv run ruff check src_dir/)Manual testing details:
Screenshots/Recordings
Related Issues
Deployment Notes
Checklist