-
Notifications
You must be signed in to change notification settings - Fork 2
Protein Visualization and Heatmap Fixes #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davereinhart
wants to merge
12
commits into
release-2025.6.0
Choose a base branch
from
davereinhart/protein-viz-fixes
base: release-2025.6.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponding protein visualization data based on residue position rather than index
…to corresponding X scale domain values
…r heatmap starting at position 2
…with no assigned score
…m null scores having no color and showing white background
…top of other elements when in full screen mode
…xist within target range
…ng mapped coordinates
… off-white pivot color used in color scale This is to address the issue of heatmap cells with near-baseline scores appearing the same as those with no data. This also changes removes the background color on the heatmap controls element, instead using a top and bottom border, for less of a visual break between the content above and below the controls.
…value is present for current colorBy attribute
… selection rectangles when selection is out of range Stores min and max X in heatmap content object, to use when selecting a column range is outside of these values. This can occur when selecting residues in a protein visualization that do not appear in the heatmap, and in these cases it will no longer create a selection rectangle rather than defaulting to the first column.
…ost-mapped HGVS coordinates or if scoreset is accession-based
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves protein structure viewer and heatmap with better coordinate handling, visual consistency, and selection mechanisms.