Skip to content

Conversation

@kingtaurus
Copy link
Contributor

This fixes issue #22 [minor] Use the available packaged libraries for libedit. Possible issues with this pull request - there can be a conflict with libbsd:i386 and libbsd:amd64 (there is a collision between the contents of the packages in some versions associated 14.04). In addition there are a few additional packages that have to be installed.

README.md:
(1) Added additional set of packages to be installed;
This includes libedit, ncurses, gcc-dev libraries;

src/CMakeLists.txt:
(1) Removed the inclusion of libedit (within the repository);
(2) Added simple cmake finding of the libraries necessary to build voglperf;

DELETED src/libedit-3.1/
(1) No longer needed;

NOTE: The license should be the same.[Hopefully someone can verify this];

README.md:
  (1) Added additional set of packages to be installed;
      This includes libedit, ncurses, gcc-dev libraries;

src/CMakeLists.txt:
  (1) Removed the inclusion of libedit (within the repository);
  (2) Added simple cmake finding of the libraries necessary to build voglperf;

DELETED src/libedit-3.1/
  (1) No longer needed;

NOTE: The license should be the same.[Hopefully someone can verify this];
@JonnyJD
Copy link

JonnyJD commented Oct 31, 2015

Thanks, I am successfully using this patch on the package on Arch Linux, originally as a fix to this problem:

src/voglperf-0.2/src/libedit-3.1/lib/x86_64-linux-gnu/libedit.a(el.o): relocation R_X86_64_32S against `.rodata' can not be used when making a shared object; recompile with -fPIC

Maybe google will lead people here when they have the same problem.
Note that the second patch from #10 is also necessary when patching the 0.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants