Fix html motd window reloading whenever any other panels are displayed.#1924
Open
bottiger1 wants to merge 1 commit into
Open
Fix html motd window reloading whenever any other panels are displayed.#1924bottiger1 wants to merge 1 commit into
bottiger1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When you are viewing an HTML motd and if you spawn/die/round end or any situation where new panels are shown, the motd will be forcefully refreshed, causing flashing and anyone that scrolled down or clicked on another link would lose their navigation state.
Why this happens:
When any panel is shown, UpdateAllPanels() is called which then calls Update() on all panels including the motd.
How this is fixed:
We record if the panel is showing html and the url. If upon calling Update() it is html and the same url, we don't redraw it.