[TF2] Use correct activity in C_BaseObject placement hack#1813
Open
inco-cc wants to merge 1 commit intoValveSoftware:masterfrom
Open
[TF2] Use correct activity in C_BaseObject placement hack#1813inco-cc wants to merge 1 commit intoValveSoftware:masterfrom
inco-cc wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies an existing hack in
C_BaseObject::Simulateto set the correct activity on the client when an object is placed on the server before the client knows that it was a valid placement position. It also restores its animation playback rate prior to setting the activity, since setting an activity resets the playback rate to1.0.Currently, the hack sets the
ACT_OBJ_RUNNINGactivity, which makes objects appear dormant while they're being built. This modification setsACT_OBJ_ASSEMBLINGif the object is currently being built, otherwise it usesACT_OBJ_RUNNING.This also prevents another related issue in MvM where a teleporter will start playing its spin animation after being placed in this particular edge case, even when its matching teleporter isn't online.
Before:
before.webm
before-mvm.webm
After:
after.webm
after-mvm.webm