Fix race condition in CUtlSymbolTableMT lookup#1807
Open
ficool2 wants to merge 1 commit intoValveSoftware:masterfrom
Open
Fix race condition in CUtlSymbolTableMT lookup#1807ficool2 wants to merge 1 commit intoValveSoftware:masterfrom
ficool2 wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
dimhotepus
reviewed
Feb 16, 2026
| class CStringPoolIndexSearch : public CStringPoolIndex | ||
| { | ||
| public: | ||
| CStringPoolIndexSearch( const char* pString ) : CStringPoolIndex( 0xFFFF, 0xFFFF ) |
dimhotepus
approved these changes
Feb 16, 2026
dimhotepus
added a commit
to Source-Authors/Obsoletium
that referenced
this pull request
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #612 for an explanation of how the race condition arises
This PR puts the search string on the stack, which prevents threads from reading a stale pointer that got switched out between execution
This mainly fixes flickering water materials. Materialsystem uses a CUtlSymbolTableMT lookup for material vars internally, and therefore it will occasionally read a stale state for fog parameters