Skip to content

Comments

[TF2] fix Jarate and Mad Milk splash AoE using a cube rather than a sphere#1779

Open
wgetJane wants to merge 1 commit intoValveSoftware:masterfrom
wgetJane:jar-sphere-fix
Open

[TF2] fix Jarate and Mad Milk splash AoE using a cube rather than a sphere#1779
wgetJane wants to merge 1 commit intoValveSoftware:masterfrom
wgetJane:jar-sphere-fix

Conversation

@wgetJane
Copy link
Contributor

Description

partially fixes ValveSoftware/Source-1-Games/issues/5905

https://youtube.com/watch?v=1hYZbyUK170

i will note that the consequence of this fix is definitely a noticeable balance change, however the affected weapons generally seem to be deemed to be overpowered by the community anyway

maybe this fix might need to be disabled specifically for mvm? idk what the opinion is for this

video:

simplescreenrecorder-2026-01-27_15.08.48.mp4

if ( !pPlayer->IsAlive() )
continue;

// UTIL_EntitiesInSphere actually uses a cube rather than a sphere
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than having to hack this in at every place where UTIL_EntitiesInSphere is called, this should just be done in UTIL_EntitiesInSphere itself

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree but this is supposed to be a bit more of a conservative approach for now since this would affect quite a lot of other things (airblast, dispensers, etc)

@old702
Copy link

old702 commented Feb 2, 2026

Maybe, to preserve the interaction volume so it doesn’t feel like a balance change, a coefficient could be applied that keeps the sphere’s volume equivalent to the box’s volume.
Then this could be applied to airblast, dispensers, etc.

Something like:
r(new) = r × 1.24 (so the volume roughly matches the old AABB).

I think that because of the quirks of not rotating boxes, this could also be applied to airblast, which would reduce the blind spots in the cone check logic that occur due to alignment with world axes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TF2] spheres are not spheres

3 participants