-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[TF2] Fix pyrovision effect for mods on TF2. #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
You have no idea how i was going crazy over this, apparently this bug DOESN'T HAPPEND to some users, my initial tought was like my Graphic card being faulty (despite not, and being fine around every other single game), and all of this because of flashlights?! 😭 |
|
In fact it DOES depend on GPU. Old gpus and intel. I think thats something regarding dx9 implementation on newer and some older gpus. Flashlight implementation is pretty messy. |
it's a really crazy Discovery, for context, mine is a RTX 4060 TI, and it's fairly new, so stuff like this kinda makes you worried, but good finding. |
| //this check is only for tf mods, because pyrovision is only tf thing | ||
| #if defined( TF_CLIENT_DLL ) | ||
| { | ||
| ConVarRef( "mat_supportflashlight" ).SetValue( false ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wrong way to fix this, fix the issue in the shader rather than disabling flashlights entirely...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but I'm very bad at shaders. And since I saw this way to fix this in the materialsystem, I decided that it would be faster for ordinary people to add these lines to fix it on the spot.
|
What do you mean by "This happens only in mods, and not in default tf"? Team_Fortress_2_-_2025-06-21_11-51-14_p-m-_1.mp4 |
|
Pretty sure this is the true vision of what Pyro sees. I had some similar issues outside of Pyrovision that kinda looked similar, shown here. Not sure if it's related. I've also seen this same artifact happen in someone else's game who doesn't use Vulkan, so probably unrelated to that. |
|
@JoriKos
|
I've only had this bug in that specific spot, at specific view angles, on that map. I've never seen it happen anywhere else. |
|
I wasnt able to reproduce the bug on that spot, but if(!!!) its the same issue, this fix should work. |
|
I should note I found some other spots with this issue, so it's not specific to that spot but just one I found it to happen quite consistently for me. |
While pyrovision is on, overlays freaks out. This happens only in mods, and not in default tf.
2025-12-13_18-42-07.mp4
After this commit.
2025-12-13_18-58-20.mp4
Hardcoded check for gameinfo folder that prevented this was in materialsystem, but mods cant modify this, so check falsely sets mat_supportflashlight as true. Setting mat_supportflashlight in CHLClient::Init for TF fixes this issue for mods.