Clean up layering loop #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subdiff
commented
Feb 26, 2020
Author
|
I have removed again in the new version resetting all values of layers that had been used in the past for now because in theory it should also work without that. Need to check out libliftoff in this regard. For better debugging of it see also emersion/libliftoff#43. |
Trying to layer onto planes should be continued when fb ids are set and not the other way around. Here the assert also failed when only having one layer.
Activate libliftoff's internal log when layers are enabled and the parameter 'd' is provided. Note: this needs some patches to libliftoff to make the debug readable that I have proposed upstream.
Restructure the loop a bit to have less code repetition and make it easier to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying the layering I first failed on an assert. That's the second patch.
Then there was a second problem that as soon as I started a game (CS GO) the screen became black. I noticed that if I reset all values of layers that were used in the past but not anymore the game was shown after a certain amount of time.
The reason: as soon as the mouse cursor and the info message in right lower corner was hidden it showed. The cursor or the info message were on a second layer. Whenever there are more than one layer the layer below becomes black. This could be a bug in libliftoff or the kernel driver (tested with RX 5700 XT).
Resetting all values for now is part of the first patch, which does also overall tidy up the loop a bit and adds some verbose debug statements for the loop that can be activated via command line parameter.