build: Compilation fixes for MinGW toolchain#374
Closed
ManManson wants to merge 3 commits intoValveSoftware:masterfrom
Closed
build: Compilation fixes for MinGW toolchain#374ManManson wants to merge 3 commits intoValveSoftware:masterfrom
ManManson wants to merge 3 commits intoValveSoftware:masterfrom
Conversation
ManManson
force-pushed
the
mingw_build_fixes
branch
from
76af1b0 to
20a64f1
Compare
There are no `TraceLoggerProvider.h` or `winmeta.h` headers in MinGW w32api package, so just disable the support for TraceLoggerProvider interfaces. Signed-off-by: Pavel Solodovnikov <pavel.al.solodovnikov@gmail.com>
…uilds Signed-off-by: Pavel Solodovnikov <pavel.al.solodovnikov@gmail.com>
…ng in `IsIPv6AllZeroes()` C-style cast from `uint8*` to `uint64*` is unsafe and can blow up in cases when the source pointer is not aligned to `uint64` type requirements. Signed-off-by: Pavel Solodovnikov <pavel.al.solodovnikov@gmail.com>
ManManson
force-pushed
the
mingw_build_fixes
branch
from
20a64f1 to
5a7c2dd
Compare
Contributor
|
Thanks! Sorry for the very slow reply. I merged almost all of these changes. I didn't merge the changes to steamnetworkingsockets_lowlevel.cpp because I think those functions should have stubs and don't need explicit surrounding guards. Let me know if I'm wrong. |
Contributor
Author
|
It probably was due to missing Although, it's not a big deal to provide a few extra defines. I'll revisit this a bit later and will provide a follow-up patch in case your changes aren't sufficient for a successful MinGW build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset incorporates a few fixes for build errors and warnings found when building GNS via llvm-mingw toolchain:
cmsghdr-related things in MinGW builds (MinGW requires to include a different header file + need to alias WSACMSGHDR* to CMSGHDR/cmsghdr to avoid compilation errors)-wcast-alignwarning inIsIPv6AllZeroes()