-
Notifications
You must be signed in to change notification settings - Fork 8
Custom Operator Registry Support #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ajay-mk
wants to merge
64
commits into
master
Choose a base branch
from
ajay/feature/runtime-op-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature/runtime-op-support
All connectivity info is now encoded using plain strings
All connectivity info is now encoded using plain strings
…ation order Constructors now take strings as Operator identifiers
…f perturbation order. Perturbation order does not make any difference on how the operator acts, so it is only for bookkeeping here.
All methods except A and S will check registry make sure the Operator label is registered.
…eature/runtime-op-support
Uses SEQUANT_CONTEXT_MANIPULATION_THREADSAFE CMake variable to toggle safety (same as core::Context)
fe8a7d9 to
1fe1c93
Compare
Initial idea was to keep this within MBPT. But looks like some core features also depend on A and S labels.
Updates in both core and mbpt modules
4040245 to
40e6366
Compare
Similar to core::Context
This method is mostly for debugging convenience, so its fine.
Updates includes and usages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom Operator Registry Support
This PR refactors Operator logic from depending on a predefined
OpTypeenum to a runtimeOpRegistry, enabling users to define custom operators beyond the predefined set.Major Changes
OpRegistry: a registry for operator labels and their classificationsmbpt::Contextnow holds anOpRegistryalong with the CSV setting.OpTypeenum is removed, all related logic is gone:OpMakerconstructors now use strings.OpConnectionsnow uses strings to specify operator pairs. For example:{{L"f", L"A"}, {L"g", L"A"}, ...}mbpt::Contextmanipulations are thread-safe, and can be toggled bySEQUANT_CONTEXT_MANIPULATION_THREADSAFEoption; follows the same pattern ascore::Context.Example Usage
TODO
L"A"andL"S"and replace them with functions.