Extract TooManyRequests and ServerError checks#2881
Closed
adamtheturtle wants to merge 1 commit intomainfrom
Closed
Extract TooManyRequests and ServerError checks#2881adamtheturtle wants to merge 1 commit intomainfrom
adamtheturtle wants to merge 1 commit intomainfrom
Conversation
Move HTTP status code checks for TooManyRequests (429) and ServerError (5xx) from VWS.make_request and VuMarkService.generate_instance_uuid into target_api_request, eliminating duplication and centralizing error handling. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves HTTP status code checks for
TooManyRequests(429) andServerError(5xx) fromVWS.make_requestandVuMarkService.generate_instance_uuidintotarget_api_request. This centralizes error handling and eliminates duplication across the two callsites.Test plan
🤖 Generated with Claude Code
Note
Low Risk
Low risk refactor that centralizes existing HTTP error checks; behavior should remain the same aside from ensuring all
target_api_requestcallers now consistently raise on 429 and 5xx responses.Overview
Centralizes HTTP status handling by moving
TooManyRequestsError(429) andServerError(5xx) checks intotarget_api_request, and documenting these raises there.Removes the duplicated 429/5xx guard code and related imports from
VWS.make_requestandVuMarkService.generate_vumark_instance, so both rely on the shared request helper for these error cases.Written by Cursor Bugbot for commit 4bdab9d. This will update automatically on new commits. Configure here.