Rename transport timeout parameter to request_timeout#2879
Merged
adamtheturtle merged 1 commit intomainfrom Feb 24, 2026
Merged
Rename transport timeout parameter to request_timeout#2879adamtheturtle merged 1 commit intomainfrom
adamtheturtle merged 1 commit intomainfrom
Conversation
Avoids triggering ruff ASYNC109 (which flags async functions with a `timeout` parameter) without needing a lint suppression. The name `request_timeout` is also more descriptive of its purpose as an HTTP request timeout passed through to httpx/requests. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeoutparameter torequest_timeoutacross theTransportprotocol, all transport implementations (RequestsTransport,HTTPXTransport), and their callersTest plan
🤖 Generated with Claude Code
Note
Low Risk
Mechanical parameter rename across a small surface area; main risk is breaking downstream/custom transports or callers that still pass
timeout.Overview
Renames the transport keyword argument
timeouttorequest_timeoutacross theTransportprotocol and bothRequestsTransport/HTTPXTransportimplementations, and updates call sites in_vws_request.pyandCloudRecoService.query().Adjusts
HTTPXTransport’s internal timeout handling to use the renamed parameter and updates transport tests to passrequest_timeout.Written by Cursor Bugbot for commit 90a452e. This will update automatically on new commits. Configure here.