Skip to content

Rename transport timeout parameter to request_timeout#2879

Merged
adamtheturtle merged 1 commit intomainfrom
adamtheturtle/rename-timeout-to-request-timeout
Feb 24, 2026
Merged

Rename transport timeout parameter to request_timeout#2879
adamtheturtle merged 1 commit intomainfrom
adamtheturtle/rename-timeout-to-request-timeout

Conversation

@adamtheturtle
Copy link
Member

@adamtheturtle adamtheturtle commented Feb 24, 2026

Summary

  • Renames the timeout parameter to request_timeout across the Transport protocol, all transport implementations (RequestsTransport, HTTPXTransport), and their callers
  • Avoids needing a lint suppression for ruff ASYNC109 when async transport support is added
  • More descriptive name clarifying this is an HTTP request timeout passed to httpx/requests

Test plan

  • All existing transport tests pass with renamed parameter
  • mypy and ruff pass with zero errors

🤖 Generated with Claude Code


Note

Low Risk
Mechanical parameter rename across a small surface area; main risk is breaking downstream/custom transports or callers that still pass timeout.

Overview
Renames the transport keyword argument timeout to request_timeout across the Transport protocol and both RequestsTransport/HTTPXTransport implementations, and updates call sites in _vws_request.py and CloudRecoService.query().

Adjusts HTTPXTransport’s internal timeout handling to use the renamed parameter and updates transport tests to pass request_timeout.

Written by Cursor Bugbot for commit 90a452e. This will update automatically on new commits. Configure here.

Avoids triggering ruff ASYNC109 (which flags async functions with a `timeout` parameter) without needing a lint suppression. The name `request_timeout` is also more descriptive of its purpose as an HTTP request timeout passed through to httpx/requests.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@adamtheturtle adamtheturtle merged commit ba47b78 into main Feb 24, 2026
16 checks passed
@adamtheturtle adamtheturtle deleted the adamtheturtle/rename-timeout-to-request-timeout branch February 24, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant