Skip to content

Fix wait_for_target_processed returning before status is stable #2869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 2 commits into from
Feb 23, 2026
Merged

Fix wait_for_target_processed returning before status is stable #2869

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
035b73c
Fix wait_for_target_processed returning before status is stable.
adamtheturtle Feb 23, 2026
ccd60bd
Simplify verification to just a sleep to maintain 100% coverage.
adamtheturtle Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/vws/vws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,10 @@ def wait_for_target_processed(
while True:
report = self.get_target_summary_report(target_id=target_id)
if report.status != TargetStatuses.PROCESSING:
# Guard against the target still being seen as
# processing by other endpoints due to eventual
# consistency.
time.sleep(seconds_between_requests)
Copy link

@cursor cursor bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing re-verification after sleep defeats confirmation purpose

Medium Severity

The PR description states this change will "sleep and verify status once more before returning," but the implementation only calls time.sleep and then unconditionally returns without re-querying get_target_summary_report. There is no actual confirmation check — if the initial non-PROCESSING status was a transient read due to eventual consistency, the method still returns as if the target is fully processed. The sleep alone doesn't guard against the scenario described in the comment if the summary report endpoint itself can return stale data.

Fix in Cursor Fix in Web

return

elapsed_time = time.monotonic() - start_time
Expand Down