Skip to content

Replace urljoin with string concatenation for base URL construction #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 8 commits into from
Feb 22, 2026
Merged

Replace urljoin with string concatenation for base URL construction #2867

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2946610
Replace urljoin with string concatenation for base URL construction
adamtheturtle Feb 22, 2026
365c501
Fix urljoin in query.py and add path-prefix base URL tests
adamtheturtle Feb 22, 2026
b4ecf17
Simplify path-prefix tests: use MockVWS + ConnectionError
adamtheturtle Feb 22, 2026
da75463
Use keyword argument for pytest.raises
adamtheturtle Feb 22, 2026
115bd8d
Bump vws-python-mock to 2026.2.22.1
adamtheturtle Feb 22, 2026
ec3c968
Add positive path-prefix tests and fix auth signing for prefixed base…
adamtheturtle Feb 22, 2026
1659038
Bump vws-python-mock to 2026.2.22.2 and clean up path-prefix handling
adamtheturtle Feb 22, 2026
13a0047
Use implicit booleaness check in path-prefix test
adamtheturtle Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/vws/_vws_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
API.
"""

from urllib.parse import urljoin

import requests
from beartype import BeartypeConf, beartype
from vws_auth_tools import authorization_header, rfc_1123_date
Expand Down Expand Up @@ -64,7 +62,7 @@ def target_api_request(
**extra_headers,
}

url = urljoin(base=base_vws_url, url=request_path)
url = base_vws_url.rstrip("/") + request_path
Comment thread
cursor[bot] marked this conversation as resolved.

requests_response = requests.request(
method=method,
Expand Down