[codex] Use assert_never for enum fallbacks#3177
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the enum fallback
case _pragmas in the Flask VWS, VWQ, and target-manager settings helpers with exhaustiveassert_neverbranches. The enum match arms now use qualified enum members and explicit receiver annotations so strict match checkers can prove the fallback is unreachable. Adds a coverage exclusion for thatassert_neverpattern, matching the sibling-repo convention. Validated via commit and push hooks, including ruff, mypy, pyright, ty, and pyrefly.Note
Low Risk
Low risk: changes are limited to enum-to-implementation helper methods and coverage configuration, with no behavioral changes expected unless an impossible enum value is encountered.
Overview
Updates the Flask mock servers’ enum helper methods (image matcher and target rater selection) to use exhaustive
matchstatements: arms now reference qualified enum members, add explicitselfannotations, and replace the prior fallbackcase _/ValueErrorwithcase _ as unreachable: assert_never(unreachable).Adjusts
coverageconfig to exclude the newassert_neverunreachable-branch pattern from coverage reporting.Reviewed by Cursor Bugbot for commit 6cb4d7f. Bugbot is set up for automated code reviews on this repo. Configure here.