Start Docker for Windows tests#3173
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starts the Docker service in the Windows test job and waits for
docker infobefore running pytest.This addresses CI failures where the Windows worker reached Docker tests before the daemon pipe was available.
Validated with
actionlintand the repository commit/push hooks.Note
Low Risk
Low risk CI-only change that adds a wait-for-Docker step on Windows runners; main risk is increased job time or failures if the Docker service is unavailable.
Overview
Adds a
Start Dockerstep to the Windows test workflow to start the Docker Windows service if needed and polldocker info(with a 2-minute timeout) before executing the test suite, reducing flakiness in Docker-dependent tests.Reviewed by Cursor Bugbot for commit f5e32f9. Bugbot is set up for automated code reviews on this repo. Configure here.