Use sync clients in respx transport tests#3020
Merged
adamtheturtle merged 1 commit intomainfrom Feb 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert tests/mock_vws/test_respx_mock_usage.py from async vws clients to synchronous VWS, CloudRecoService, and VuMarkService usage. Inject HTTPXTransport() so the tests still exercise the respx/httpx interception path while removing asyncio.run, async with, and await. Verified with uv run --extra dev pytest tests/mock_vws/test_respx_mock_usage.py -q (5 passed).
Note
Low Risk
Test-only refactor switching from async to sync client APIs while keeping the same mocked HTTPX/respx interception path; low blast radius outside of potential test behavior differences (timeouts/context management).
Overview
Updates the
MockVWS/respx transport tests to use synchronousvwsclients (VWS,CloudRecoService,VuMarkService) instead of async variants.Removes
asyncio.run,async with, andawait, and explicitly injectsHTTPXTransport()so requests still flow through thehttpxinterception path while exercising the same timeout, base-URL-prefix, target lifecycle, query, and VuMark image generation scenarios.Written by Cursor Bugbot for commit a96d77e. This will update automatically on new commits. Configure here.