Skip to content

Use verify_mock_vuforia on TestTargetStatusNotSuccess#3006

Merged
adamtheturtle merged 5 commits intomainfrom
adamtheturtle/add-verify-mock-vuforia
Feb 23, 2026
Merged

Use verify_mock_vuforia on TestTargetStatusNotSuccess#3006
adamtheturtle merged 5 commits intomainfrom
adamtheturtle/add-verify-mock-vuforia

Conversation

@adamtheturtle
Copy link
Member

@adamtheturtle adamtheturtle commented Feb 22, 2026

Summary

  • Added processing_target_id field to VuMarkCloudDatabase fixture to support testing VuMark targets in processing state across all test backends
  • Refactored _vumark_database() to include both a success-state and processing-state VuMark target in the mock setup
  • Updated Docker backend fixture to iterate over all VuMark targets instead of unpacking a single target
  • Refactored TestTargetStatusNotSuccess test methods to accept vumark_vuforia_database fixture and removed internal MockVWS contexts, enabling these tests to run against real Vuforia, in-memory mock, and Docker mock backends via @pytest.mark.usefixtures("verify_mock_vuforia")
  • Removed unused imports (MockVWS, VuMarkDatabase, VuMarkTarget) from test file

🤖 Generated with Claude Code


Note

Medium Risk
Moderate risk because it changes test fixtures and backend setup shared across multiple test backends (real, in-memory, docker), which can affect test determinism and CI behavior; no production code paths are modified.

Overview
Adds a new processing_target_id to the vumark_vuforia_database credentials fixture (auto-generated when not provided) to support consistently referencing a VuMark target intended to remain in PROCESSING.

Updates the mock/docked backend setup to provision two VuMark targets (ready + long-processing) and, for the docker-backed mock, iterates over all vumark_targets when posting them to the Target Manager API.

Refactors VuMark generation tests to rely on the shared fixtures/backends instead of ad-hoc MockVWS setup: the “successful target” test now runs under verify_mock_vuforia (all backends), while PROCESSING-state assertions are moved into a mock-only TestProcessingTarget using mock_only_vuforia, and unused mock imports are removed.

Written by Cursor Bugbot for commit 2b51f08. This will update automatically on new commits. Configure here.

Updated TestTargetStatusNotSuccess class to use the verify_mock_vuforia fixture, enabling tests to run against multiple Vuforia backends (real, in-memory mock, and Docker mock). Extended VuMarkCloudDatabase with a processing_target_id field to support testing target processing states across all backends. Refactored test methods to use fixture-provided credentials instead of creating their own MockVWS contexts.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
The CI secrets files do not yet include VUMARK_VUFORIA_PROCESSING_TARGET_ID,
so making it required broke all tests that depend on verify_mock_vuforia
(which uses vumark_vuforia_database) at setup. Giving the field a
default_factory restores fixture setup for existing CI runs while still
allowing the env var to override it when a real Vuforia processing target
is available.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
VuMark targets cannot be added via the VWS API — they are configured
through the Vuforia Target Manager portal — so there is no way to keep
a target in PROCESSING state indefinitely on real Vuforia. Move the
processing tests into a new TestProcessingTarget class that uses
mock_only_vuforia, and keep test_successful_target in
TestTargetStatusNotSuccess with verify_mock_vuforia.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

test_successful_target was the only method left in
TestTargetStatusNotSuccess, contradicting the class name. It fits
naturally with the other generation tests in TestGenerateInstance.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adamtheturtle adamtheturtle merged commit d30a491 into main Feb 23, 2026
12 checks passed
@adamtheturtle adamtheturtle deleted the adamtheturtle/add-verify-mock-vuforia branch February 23, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant