Use verify_mock_vuforia on TestTargetStatusNotSuccess#3006
Merged
adamtheturtle merged 5 commits intomainfrom Feb 23, 2026
Merged
Use verify_mock_vuforia on TestTargetStatusNotSuccess#3006adamtheturtle merged 5 commits intomainfrom
adamtheturtle merged 5 commits intomainfrom
Conversation
Updated TestTargetStatusNotSuccess class to use the verify_mock_vuforia fixture, enabling tests to run against multiple Vuforia backends (real, in-memory mock, and Docker mock). Extended VuMarkCloudDatabase with a processing_target_id field to support testing target processing states across all backends. Refactored test methods to use fixture-provided credentials instead of creating their own MockVWS contexts. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
The CI secrets files do not yet include VUMARK_VUFORIA_PROCESSING_TARGET_ID, so making it required broke all tests that depend on verify_mock_vuforia (which uses vumark_vuforia_database) at setup. Giving the field a default_factory restores fixture setup for existing CI runs while still allowing the env var to override it when a real Vuforia processing target is available. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
VuMark targets cannot be added via the VWS API — they are configured through the Vuforia Target Manager portal — so there is no way to keep a target in PROCESSING state indefinitely on real Vuforia. Move the processing tests into a new TestProcessingTarget class that uses mock_only_vuforia, and keep test_successful_target in TestTargetStatusNotSuccess with verify_mock_vuforia. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
test_successful_target was the only method left in TestTargetStatusNotSuccess, contradicting the class name. It fits naturally with the other generation tests in TestGenerateInstance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processing_target_idfield toVuMarkCloudDatabasefixture to support testing VuMark targets in processing state across all test backends_vumark_database()to include both a success-state and processing-state VuMark target in the mock setupTestTargetStatusNotSuccesstest methods to acceptvumark_vuforia_databasefixture and removed internalMockVWScontexts, enabling these tests to run against real Vuforia, in-memory mock, and Docker mock backends via@pytest.mark.usefixtures("verify_mock_vuforia")MockVWS,VuMarkDatabase,VuMarkTarget) from test file🤖 Generated with Claude Code
Note
Medium Risk
Moderate risk because it changes test fixtures and backend setup shared across multiple test backends (real, in-memory, docker), which can affect test determinism and CI behavior; no production code paths are modified.
Overview
Adds a new
processing_target_idto thevumark_vuforia_databasecredentials fixture (auto-generated when not provided) to support consistently referencing a VuMark target intended to remain in PROCESSING.Updates the mock/docked backend setup to provision two VuMark targets (ready + long-processing) and, for the docker-backed mock, iterates over all
vumark_targetswhen posting them to the Target Manager API.Refactors VuMark generation tests to rely on the shared fixtures/backends instead of ad-hoc
MockVWSsetup: the “successful target” test now runs underverify_mock_vuforia(all backends), while PROCESSING-state assertions are moved into a mock-onlyTestProcessingTargetusingmock_only_vuforia, and unused mock imports are removed.Written by Cursor Bugbot for commit 2b51f08. This will update automatically on new commits. Configure here.